Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimise query leadership schedule command #4250

Merged
merged 1 commit into from
Dec 22, 2022
Merged

Optimise query leadership schedule command #4250

merged 1 commit into from
Dec 22, 2022

Conversation

newhoggy
Copy link
Contributor

@newhoggy newhoggy commented Aug 1, 2022 •
edited
Loading

Depends on #4392

Resolves #4325

@newhoggy newhoggy changed the title Newhoggy/optimise query leadership schedule command Optimise query leadership schedule command Aug 1, 2022
@newhoggy newhoggy force-pushed the newhoggy/optimise-query-leadership-schedule-command branch from a38ad48 to 780dae1 Compare August 1, 2022 13:22
This was referenced Aug 9, 2022
Closed
Open
@CarlosLopezDeLara
Copy link
Contributor

Requires IntersectMBO/ouroboros-network#3932 to be merged first.

@CarlosLopezDeLara CarlosLopezDeLara mentioned this pull request Aug 12, 2022
Closed
@newhoggy newhoggy force-pushed the newhoggy/optimise-query-leadership-schedule-command branch from 780dae1 to 801233e Compare August 17, 2022 12:49
@newhoggy newhoggy force-pushed the newhoggy/optimise-query-leadership-schedule-command branch 3 times, most recently from 62fcc1a to ae0dcf6 Compare August 22, 2022 03:30
@newhoggy newhoggy force-pushed the newhoggy/optimise-query-leadership-schedule-command branch from ae0dcf6 to b1be75e Compare September 3, 2022 00:57
@newhoggy newhoggy mentioned this pull request Sep 3, 2022
Merged
@newhoggy newhoggy force-pushed the newhoggy/optimise-query-leadership-schedule-command branch from b1be75e to 2a2e975 Compare December 9, 2022 06:43
Jimbo4350
Jimbo4350 previously requested changes Dec 9, 2022
View reviewed changes
Copy link
Contributor

@Jimbo4350 Jimbo4350 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, some minor changes. Can you also include in the commit message that the enhancement is due to us sending only the pool distribution over the wire vs the entire epoch state?

cardano-node/src/Cardano/Node/Tracing/Tracers/P2P.hs Outdated Show resolved Hide resolved
cardano-api/src/Cardano/Api/LedgerState.hs
let markSnapshotPoolDistr :: Map (SL.KeyHash 'SL.StakePool Shelley.StandardCrypto) (SL.IndividualPoolStake Shelley.StandardCrypto)
markSnapshotPoolDistr = ShelleyAPI.unPoolDistr . ShelleyAPI.calculatePoolDistr . ShelleyAPI._pstakeMark
$ obtainIsStandardCrypto sbe $ ShelleyAPI.esSnapshots cEstate
let snapshot :: ShelleyAPI.SnapShot Shelley.StandardCrypto
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

cardano-api/src/Cardano/Api/Query.hs Outdated Show resolved Hide resolved
cardano-api/src/Cardano/Api/Query.hs Outdated Show resolved Hide resolved
cardano-cli/src/Cardano/CLI/Shelley/Run/Query.hs Outdated Show resolved Hide resolved
@newhoggy newhoggy force-pushed the newhoggy/optimise-query-leadership-schedule-command branch 2 times, most recently from 5d574a8 to 6c5e764 Compare December 12, 2022 03:13
@newhoggy newhoggy removed the request for review from denisshevchenko December 12, 2022 03:17
@newhoggy newhoggy dismissed Jimbo4350’s stale review December 12, 2022 03:17

Addressed comments.

@newhoggy newhoggy force-pushed the newhoggy/optimise-query-leadership-schedule-command branch from 6c5e764 to cb236c0 Compare December 12, 2022 03:24
@newhoggy newhoggy force-pushed the newhoggy/optimise-query-leadership-schedule-command branch from cb236c0 to 692e79d Compare December 22, 2022 01:14
@newhoggy
Copy link
Contributor Author

bors r+

iohk-bors bot added a commit that referenced this pull request Dec 22, 2022
@iohk-bors @newhoggy
Merge #4250
7cd5f8a 
4250: Optimise query leadership schedule command r=newhoggy a=newhoggy

Depends on #4392

Resolves #4325

Co-authored-by: John Ky <[email protected]>
@newhoggy newhoggy merged commit 0ffbd5a into master Dec 22, 2022
@iohk-bors iohk-bors bot deleted the newhoggy/optimise-query-leadership-schedule-command branch December 22, 2022 03:20
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Dec 22, 2022

Timed out.

This was referenced Jan 10, 2023
Closed
Closed
@newhoggy newhoggy mentioned this pull request Feb 16, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jimbo4350 Jimbo4350 Jimbo4350 approved these changes

@dcoutts dcoutts Awaiting requested review from dcoutts

@erikd erikd Awaiting requested review from erikd

@JaredCorduan JaredCorduan Awaiting requested review from JaredCorduan

@deepfire deepfire Awaiting requested review from deepfire

@jutaro jutaro Awaiting requested review from jutaro

@coot coot Awaiting requested review from coot

@mgmeier mgmeier Awaiting requested review from mgmeier

@fmaste fmaste Awaiting requested review from fmaste

@LudvikGalois LudvikGalois Awaiting requested review from LudvikGalois

@CarlosLopezDeLara CarlosLopezDeLara Awaiting requested review from CarlosLopezDeLara

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

query commands optimization (Performance high memory usage)
3 participants
@newhoggy @CarlosLopezDeLara @Jimbo4350